@hmaarrfk thanks for this! Let me know when this is ready for a review. There are quite a few changes here but I’m assuming they’re related to making pylint pass, right?

@leouieda i think this is ready. it is likely best to review each commit one at a time.

They are each organized in a thematic manner and it makes it more clear what the improvement is.

There are some (such as the timeout) that may be worth more discussion.

@hmaarrfk sorry for the very long delay in this. Could you please elaborate on why adding the default timeout of 5? Is that a pylint recommendation?

Not specifying the timeout really causes requests to hang.... it might have been a linting recommendation, but I've experienced this alot in our "web connected" application.

If you want to support offline, you must specify a timeout mostly everywhere.

I rebased and I think thingsare ok. let me know if iyou want anything else.

Just waiting on #373 to make sure everything is running properly here before merging.

Finally merging this! Thanks for all your hard work @hmaarrfk 🫶

no problem!